Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p1: improve bpm bench #604

Merged
merged 10 commits into from
Sep 7, 2023
Merged

p1: improve bpm bench #604

merged 10 commits into from
Sep 7, 2023

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 5, 2023

DO NOT PUSH PROJECT SOLUTIONS PUBLICLY.

And especially do NOT open pull requests with project solutions!

Please be considerate of this free educational resource.

Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
skyzh and others added 3 commits September 7, 2023 10:46
Co-authored-by: Xu <xzhseh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh
Copy link
Member Author

skyzh commented Sep 7, 2023

TL;DR:

  • add more verifications to the buffer pool manager bench so that students cannot workaround it
  • better latency policy for disk manager (1ms for random access, 0.1ms for sequential scan)

Copy link
Contributor

@fernandolis10 fernandolis10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skyzh skyzh merged commit 29cfa2a into master Sep 7, 2023
3 checks passed
@skyzh skyzh deleted the skyzh/p1-bench branch September 7, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants