Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p0-draft1 #732

Merged
merged 13 commits into from
Aug 31, 2024
Merged

p0-draft1 #732

merged 13 commits into from
Aug 31, 2024

Conversation

prashanthduvvada
Copy link
Contributor

P0 - 1st Draft version.

Copy link
Member

@apavlo apavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need PrimerHashFunction?

src/include/primer/primer_hash.h Outdated Show resolved Hide resolved
src/include/primer/primer_hash.h Outdated Show resolved Hide resolved
apavlo
apavlo previously requested changes Aug 30, 2024
Copy link
Member

@apavlo apavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good enough for P0. Minor nits.

test/primer/hyperloglog_test.cpp Outdated Show resolved Hide resolved
test/primer/hyperloglog_test.cpp Outdated Show resolved Hide resolved
@connortsui20 connortsui20 self-requested a review August 30, 2024 18:35
test/primer/hyperloglog_test.cpp Outdated Show resolved Hide resolved
@connortsui20 connortsui20 merged commit 0ba573c into master Aug 31, 2024
4 checks passed
@connortsui20 connortsui20 deleted the p0-murmur branch August 31, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants