-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buffer Pool Manager (Project 1) Refactor #734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xx01cyx
reviewed
Sep 3, 2024
connortsui20
commented
Sep 9, 2024
connortsui20
commented
Sep 9, 2024
We need to also decide if we want to put the detailed implementation hints in the writeup (website) or keep them in the doc comments. Personally, I feel that documentation should always go right next to where the function implementation is, but I also understand that I made the implementation hints really long and detailed. |
unw9527
reviewed
Sep 11, 2024
unw9527
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be the main PR for refactoring the buffer pool manager, which is the entirety of Project 1.
The overarching goal of this refactoring is to make the buffer pool manager API both thread-safe and type-safe. This means that use of raw pointers both internally and externally should be removed, and that thread-safe page guards should be the only way to interact with page data.
By doing this, we heavily limit the opportunities for misuse of the buffer pool manager API, which will in turn make the implementation and debugging of future projects (which will be much harder) easier.
Additionally, there will be implementation changes for the reference solution that will prefer indexing into arrays over raw pointers, limiting the opportunities for segfaults and memory corruption.
Here are the steps required for the refactor:
Evict()
signature #731)