Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend support for Ubuntu 24.04 #739

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rolandvarga
Copy link

@rolandvarga rolandvarga commented Sep 7, 2024

Tiny change to support current Ubuntu LTS. I tried to follow the established pattern here, but do we actually care about which version of Ubuntu is running? In the case of DARWIN we're not checking the OS version.

If the concern is to use the appropriate package manager then instead of VERSION the NAME variable could be pattern matched against:

cat /etc/os-release
PRETTY_NAME="Ubuntu 24.04 LTS"
NAME="Ubuntu"
VERSION_ID="24.04"
VERSION="24.04 LTS (Noble Numbat)"
VERSION_CODENAME=noble
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=noble
LOGO=ubuntu-logo

@connortsui20
Copy link
Member

This seems fine to me, though I'm unable to test this myself.

@skyzh
Copy link
Member

skyzh commented Sep 22, 2024

bumping distro version requires students to upgrade their LLVM version; this is better done at the beginning of the semester :(

@connortsui20 connortsui20 added the deferred This issue is documented here and someone might want to fix it later, but it takes no priority label Sep 22, 2024
@rolandvarga
Copy link
Author

bumping distro version requires students to upgrade their LLVM version; this is better done at the beginning of the semester :(

This change doesn't force anyone to have to update their dev environment. It's simply a QOL change for those who run the latest version of Ubuntu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred This issue is documented here and someone might want to fix it later, but it takes no priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants