Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit testing CI #36

Merged
merged 12 commits into from
Jul 15, 2024
Merged

Unit testing CI #36

merged 12 commits into from
Jul 15, 2024

Conversation

wangpatrick57
Copy link
Member

@wangpatrick57 wangpatrick57 commented Jul 8, 2024 •
edited
Loading

Summary: Made GitHub Action which installs dependencies and runs all unit tests in the repository.

Demo:
A successful run. You can view it here.
Screenshot 2024-07-07 at 17 56 58

Details:

  • Also fixed some benign errors in the unit tests. Some paths were previously relative and had to be changed to be absolute. I also started counting index names from 0 instead of 1, which led to another test failure.

@wangpatrick57 wangpatrick57 marked this pull request as ready for review July 8, 2024 00:23
lmwnshn
lmwnshn approved these changes Jul 14, 2024
View reviewed changes
Copy link
Collaborator

@lmwnshn lmwnshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wangpatrick57 wangpatrick57 merged commit e373554 into cmu-db:main Jul 15, 2024
1 check passed
@wangpatrick57 wangpatrick57 deleted the unittest-ci branch July 18, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmwnshn lmwnshn lmwnshn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangpatrick57 @lmwnshn