[Proposal 2: Run] Call and define benchmark tests as GitHub Action jobs & workflows #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikimanoledaki
force-pushed
the
proposal-002-run
branch
3 times, most recently
from
6759913
to
991b8f0
Compare
locomundo
reviewed
May 21, 2024
nikimanoledaki
commented
May 24, 2024
nikimanoledaki
force-pushed
the
proposal-002-run
branch
2 times, most recently
from
4377aa0
to
7c6970c
Compare
locomundo
pushed a commit
to nikimanoledaki/green-reviews-tooling
that referenced
this pull request
Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far.
locomundo
pushed a commit
to nikimanoledaki/green-reviews-tooling
that referenced
this pull request
Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far. Co-authored-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: locomundo <flavia@aknostic.com>
locomundo
force-pushed
the
proposal-002-run
branch
from
18abcdb
to
706c863
Compare
locomundo
pushed a commit
to nikimanoledaki/green-reviews-tooling
that referenced
this pull request
Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far. Signed-off-by: Flavia Paganelli <flavia@aknostic.com> Co-Authored-By: nikimanoledaki <niki.manoledaki@grafana.com>
locomundo
force-pushed
the
proposal-002-run
branch
from
706c863
to
d331d4d
Compare
locomundo
pushed a commit
to nikimanoledaki/green-reviews-tooling
that referenced
this pull request
Jun 26, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far. Co-authored-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
locomundo
force-pushed
the
proposal-002-run
branch
from
d331d4d
to
548a65e
Compare
nikimanoledaki
changed the title
nikimanoledaki
force-pushed
the
proposal-002-run
branch
from
9649002
to
17089f6
Compare
nikimanoledaki
added a commit
to nikimanoledaki/green-reviews-tooling
that referenced
this pull request
Jun 28, 2024
Worked with @nikimanoledaki offline, pushing all our changes so far. Co-authored-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
nikimanoledaki
force-pushed
the
proposal-002-run
branch
3 times, most recently
from
e783d3b
to
4b0af07
Compare
nikimanoledaki
commented
Jun 28, 2024
rossf7
reviewed
Jul 2, 2024
There was a problem hiding this comment.
@nikimanoledaki @locomundo Great job this is looking good! 🚀
A few thoughts from me. Mainly on my favourite topic. Deleting stuff! 🧹😄
nikimanoledaki
commented
Jul 9, 2024
dipankardas011
suggested changes
Jul 15, 2024
locomundo
force-pushed
the
proposal-002-run
branch
from
8d1b070
to
54ae5e8
Compare
Co-authored-by: locomundo <flavia@30mhz.com> Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> * Remove option 1 of defining job in-line * Move proposal 2 to docs/proposals * Defining test jobs for proposal 2 * Split use cases and add sections for auth, versioning Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: Niki Manoledaki <niki.manoledaki@grafana.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Co-authored-by: locomundo <flavia@aknostic.com> Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
Signed-off-by: locomundo <flavia@aknostic.com> Signed-off-by: Flavia Paganelli <flavia@aknostic.com>
locomundo
force-pushed
the
proposal-002-run
branch
from
54ae5e8
to
e2e319d
Compare
rossf7
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
LGTM
Thank you @locomundo and @nikimanoledaki for your great work on this
* Clean up empty sections to be ready to merge Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
nikimanoledaki
force-pushed
the
proposal-002-run
branch
from
f1baadc
to
89df02c
Compare
nikimanoledaki
commented
Aug 7, 2024
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
Co-authored-by: AntonioDiTuri <43536425+AntonioDiTuri@users.noreply.github.com> Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
nikimanoledaki
force-pushed
the
proposal-002-run
branch
from
8bb3606
to
5193d8c
Compare
AntonioDiTuri
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/enhancementWhat this PR does / why we need it:
This proposal provides an automated way to fetch and run the benchmark tests in a modular way.
For context, please read Proposal 1 here first :)
Which issue(s) this PR fixes:
Fixes #86
Special notes for your reviewer (optional):