This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Adding labels to .github/settings.yml #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there other labels we want/need? |
chalin
previously approved these changes
Jul 24, 2021
| - name: bug | ||
| description: "Something isn't working" | ||
| color: d73a4a | ||
| - name: documentation |
There was a problem hiding this comment.
Hmm, let's drop this (like we did for etcd.io) -- since most PRs over a website repo will be for documentation (i.e., let's take that as the default when there's no extra label).
There was a problem hiding this comment.
I was thinking about that -- but as it is one of the default labels that GitHub creates on repo creation, I wonder if there is some value in keeping it (will template users expect it, even if we don't use it).
Let's start with this very nice set. |
nate-double-u
force-pushed
the
79-adding-labels-github-settings
branch
from
0ae4149 to
0e1f735
Compare
|
(latest force-push rebases the PR on main) |
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
nate-double-u
force-pushed
the
79-adding-labels-github-settings
branch
from
0e1f735 to
81bbf2e
Compare
kapunahelewong
approved these changes
Jul 26, 2021
|
Nice, the existing label assignments were persevered. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
Note: Adding labels this way will remove labels already added via the GitHub UI.
In case GitHub isn't able to reapply labels when merging this PR, this is how they are currently applied (to open issues/PRs):
bug: #56, #52, #45
cleanup: #85
documentation: #29, #24, #23, #22
enhancement: #83, #80, #28, #27, #26, #25, #21, #20, #19, #18
infrastructure: #85, #83, #79, #68
question: #76, #87