Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes and new rules from collaboration EUMETSAT-AQCLab #230

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Bugfixes and new rules from collaboration EUMETSAT-AQCLab #230

wants to merge 32 commits into from

Commits on Dec 21, 2022

  1. Bug fix: parsing errors (COM.NAME.Homonymy: Location unreachable or I… 

    …ndexOutOfBoundsException) were produced when analyzed files contained declaration of functions or subroutines with modifiers Recursive, Elemental or Pure
    @jverdugo-aqclab
    jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    f06ee24 View commit details
    Browse the repository at this point in the history

  2. Bug fix: Parsing error (IndexOutOfBoundsException) was produced when … 

    …a file only contains comments, no source code. Also a JFlexException was thrown in the case of a file without code nor comments. The throw for this Exception has been removed to avoid parsing errors in the results.
    @jverdugo-aqclab
    jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    729b1e6 View commit details
    Browse the repository at this point in the history

  3. Bug fix: a parsing error (IndexOutOfBoundsException) was produced whe… 

    …n analyzing files that included sentences like "PROCEDURE(proc_interface), POINTER :: proc"
    @jverdugo-aqclab
    jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    50108d9 View commit details
    Browse the repository at this point in the history

  4. Rule for checking that lines of code in a file don't exceed a thresho… 

    …ld of LOC (set at 1000). Only lines of code are taken into account, comments and blank lines are ignored.
    @jverdugo-aqclab
    jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8104472 View commit details
    Browse the repository at this point in the history

  5. Rule for checking that lines of code in procedures don't exceed a thr… 

    …eshold of LOC (set at 150). Only lines of code are taken into account, comments and blank lines are ignored.
    @jverdugo-aqclab
    jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8178b61 View commit details
    Browse the repository at this point in the history

  6. Rule ArgumentsProcedure 

    Rule to check the maximum number of arguments in each procedure, which must be at most 7.
    @adiaz-aqclab @jverdugo-aqclab
    adiaz-aqclab authored and jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    53bcf92 View commit details
    Browse the repository at this point in the history

  7. Rule CyclomaticComplexity 

    Rule to check the maximum value of the cyclomatic complexity in each function, which at most must be 15.
    @adiaz-aqclab @jverdugo-aqclab
    adiaz-aqclab authored and jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    fd38d56 View commit details
    Browse the repository at this point in the history

  8. Rule LogicUnit 

    Rule to check that only one module or program is declared in each file.
    @adiaz-aqclab @jverdugo-aqclab
    adiaz-aqclab authored and jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    a35a601 View commit details
    Browse the repository at this point in the history

  9. Rule PercentageComment 

    Rule to check that in each file there are at least 30% of lines of comments with respect to the total number of lines.
    @adiaz-aqclab @jverdugo-aqclab
    adiaz-aqclab authored and jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    f3fe830 View commit details
    Browse the repository at this point in the history

  10. Rule CommentVar

    @adiaz-aqclab @jverdugo-aqclab
    adiaz-aqclab authored and jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    363f560 View commit details
    Browse the repository at this point in the history

  11. Rule Header

    @adiaz-aqclab @jverdugo-aqclab
    adiaz-aqclab authored and jverdugo-aqclab committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    fd9331d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Change new rules names to RNC rules

    Diego committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    c73b574 View commit details
    Browse the repository at this point in the history

  2. Change name in comment

    Diego committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    1b2592e View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Update fortran77-rules/src/main/resources/lex/COMFLOWCheckArguments.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8d81c1e View commit details
    Browse the repository at this point in the history

  2. Update fortran77-rules/src/main/resources/lex/COMFLOWCheckArguments.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    081584c View commit details
    Browse the repository at this point in the history

  3. Update fortran77-rules/src/main/resources/lex/COMMETComplexitySimplif… 

    …ied.lex

Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    93dbf77 View commit details
    Browse the repository at this point in the history

  4. Update fortran77-rules/src/main/resources/lex/COMMETComplexitySimplif… 

    …ied.lex

Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    0ff4252 View commit details
    Browse the repository at this point in the history

  5. Update fortran77-rules/src/main/resources/lex/COMMETLineOfCode.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    a733ffd View commit details
    Browse the repository at this point in the history

  6. Update fortran77-rules/src/main/resources/lex/COMMETLineOfCode.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    446f106 View commit details
    Browse the repository at this point in the history

  7. Update fortran90-rules/src/main/resources/lex/COMMETLineOfCode.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    3bf3c33 View commit details
    Browse the repository at this point in the history

  8. Update fortran90-rules/src/main/resources/lex/COMFLOWCheckArguments.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    23ac9c7 View commit details
    Browse the repository at this point in the history

  9. Update fortran77-rules/src/main/resources/lex/COMMETRatioComment.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    290cd74 View commit details
    Browse the repository at this point in the history

  10. Update fortran77-rules/src/main/resources/lex/COMMETRatioComment.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8e43b0c View commit details
    Browse the repository at this point in the history

  11. Update fortran90-rules/src/main/resources/lex/COMMETRatioComment.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    dd56e54 View commit details
    Browse the repository at this point in the history

  12. Update fortran90-rules/src/main/resources/lex/COMMETRatioComment.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    217f47e View commit details
    Browse the repository at this point in the history

  13. Update fortran90-rules/src/main/resources/lex/COMMETLineOfCode.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8502935 View commit details
    Browse the repository at this point in the history

  14. Update fortran90-rules/src/main/resources/lex/COMMETComplexitySimplif… 

    …ied.lex

Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    849784b View commit details
    Browse the repository at this point in the history

  15. Update fortran90-rules/src/main/resources/lex/COMMETComplexitySimplif… 

    …ied.lex

Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    af8085a View commit details
    Browse the repository at this point in the history

  16. Update fortran90-rules/src/main/resources/lex/COMFLOWCheckArguments.lex 

    Co-authored-by: Diego Rodriguez <63045276+diegorodriguez31@users.noreply.github.com>
    @jverdugo-aqclab @diegorodriguez31
    jverdugo-aqclab and diegorodriguez31 authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    ed18b31 View commit details
    Browse the repository at this point in the history

  17. Remove unused variable numTotal

    @jverdugo-aqclab
    jverdugo-aqclab committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    a66e884 View commit details
    Browse the repository at this point in the history

  18. Header updated to reflect this rule is not defined in RNC.

    @jverdugo-aqclab
    jverdugo-aqclab committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    5e8cac9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Test cases for new rules

    @jverdugo-aqclab
    jverdugo-aqclab committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    8b510ac View commit details
    Browse the repository at this point in the history