Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 处理 glob、lru-cache 等 patch 版本升级 node 依赖的问题 #253

Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix: 处理 glob、lru-cache 等 patch 版本升级 node 依赖的问题 #253

merged 2 commits into from
Jul 9, 2024

Conversation

Jiasm
Copy link
Contributor

@Jiasm Jiasm commented Jul 8, 2024 •
edited by coderabbitai bot
Loading

相关参考：isaacs/node-glob#596

Summary by CodeRabbit

  • Chores
    • Updated various package versions to improve performance, security, and compatibility.

Jiasm added 2 commits July 8, 2024 12:46
@Jiasm
fix: 处理 glob、lru-cache 等 patch 版本升级 node 依赖的问题
1710ce9 
isaacs/node-glob#596  同作者多个基础 npm 包使用 patch 版本升级 node 版本依赖，导致固定 node 版本的使用者受阻。
@Jiasm
Update package.json
0607a9b 
删除多余的逗号
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 8, 2024 •
edited
Loading

Walkthrough

The package.json file has been updated with new versions for several packages, including rimraf, node-lru-cache, jackspeak, and glob. Each update includes a justification for the change, suggesting improvements in functionality, performance, or security.

Changes

File Change Summary
package.json Updated versions for rimraf, node-lru-cache, jackspeak, and glob. Justifications for each update are provided.

Poem

In the land of package.json,
Where dependencies are drawn,
New versions rise at dawn,
rimraf, glob, and more,
Bringing updates to explore,
A better path we adorn!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 8, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 21d4fe9 and 0607a9b.

Files selected for processing (1)
  • package.json (3 hunks)
Files skipped from review due to trivial changes (1)
  • package.json

@fengmk2
Copy link
Member

fengmk2 commented Jul 8, 2024

等飞一会，看看官方的反馈。

@Jiasm
Copy link
Contributor Author

Jiasm commented Jul 9, 2024

涉及到的四个模块均发布了新的 major 版本并修改 latest 指向，但是历史版本并没有移除，结合现状来看官方应该也认为调整 node 依赖版本属于 major 变更了，具体详情：

  • glob 发布了 major 版本来指定 20 || >= 22，并发布了 patch 版本指定 14 >=14.21 || 16 >=16.20 || 18 || 20 || >=22
  • lru-cache 发布了 major 版本来指定 20 || >= 22，并发布了 minor 版本指定 14 >=14.21 || 16 >=16.20 || 18 || 20 || >=22
  • jackspeak 发布了 major 版本来指定 20 || >= 22，并发布了 patch 版本指定 14 >=14.21 || 16 >=16.20 || >=18
  • rimraf 发布了 major 版本来指定 20 || >= 22，并发布了 patch 版本指定 14 >=14.20 || 16 >=16.20 || >=18
image image image image

@fengmk2 fengmk2 merged commit f058e87 into cnpm:master Jul 9, 2024
7 checks passed
fengmk2 pushed a commit that referenced this pull request Jul 9, 2024
@semantic-release-bot
Release 1.101.2
4f90968 
[skip ci]

## [1.101.2](v1.101.1...v1.101.2) (2024-07-09)

### Bug Fixes

* 处理 glob、lru-cache 等 patch 版本升级 node 依赖的问题  ([#253](#253)) ([f058e87](f058e87))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiasm @fengmk2