Skip to content

Commit

Permalink
Resubmission remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
coatless committed Jan 28, 2018
1 parent 165e411 commit 5bd38a7
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,28 @@ Found the following (possibly) invalid URLs:
- Because this is a new release, the above URL has yet to be activated as
the website only contains active packages on CRAN.

## Resubmit Remarks

From the initial submission, Uwe commented:

> Thanks, we see all your examples are in `\dontrun{}` and your tests are
> rather sparse.
> Can you somehow test the core functionality of your package, too?
I have since:

1. Unlocked all examples and added an example for `enable_error_shim()`/`disable_error_shim()`
2. Improved the unit tests:
- Verification that a `call` has been registered in `options(error = ...)`
- An output comparison of the function registered as the `options(error= ...)`
handler and the default search function.
- Checks surrounding the state of the `.errorist_env` when `errorist` is enabled.
3. Added a brief vignette to complement the extensive `README.md` file

Details of the code changes can be seen here:

<https://github.com/coatless/errorist/compare/165357dcf4c76bc4bd35b0049a47799f0c724fdb...master>

## Reverse dependencies

This is a new release, so there are no reverse dependencies.

0 comments on commit 5bd38a7

Please sign in to comment.