Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image refresh for services #5557

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Image refresh for services #5557

merged 1 commit into from
Nov 17, 2023
+1 −1

Conversation

cockpituous
Copy link
Contributor

@cockpituous cockpituous commented Nov 17, 2023 •
edited
Loading

Image refresh for services

  • image-refresh services

@cockpituous cockpituous changed the title Image refresh for services WIP: 4-ci-srv-03: [no-test] Image refresh for services Nov 17, 2023
@cockpituous cockpituous changed the title Image refresh for services WIP: rhos-01-32: [no-test] Image refresh for services Nov 17, 2023
@martinpitt
Copy link
Member

I triggered this manually to cross-check cockpit-project/cockpit#19615 (comment) whether the current samba image improves the testClientCertAuthentication. It doesn't fix it locally, but it seems to happen much less often for me.

@martinpitt martinpitt mentioned this pull request Nov 17, 2023
Merged
@cockpituous
Copy link
Contributor Author

image-refresh services done: https://github.com/cockpit-project/bots/commits/image-refresh-services-20231117-122322

@cockpituous cockpituous force-pushed the image-refresh-services-20231117-122322 branch from 66fa5ad to b5fd035 Compare November 17, 2023 12:23
@cockpituous cockpituous changed the title WIP: rhos-01-32: [no-test] Image refresh for services Image refresh for services Nov 17, 2023
@cockpituous
Copy link
Contributor Author

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/services-20231117-122323.log

@cockpituous
Copy link
Contributor Author

image-refresh services done: https://github.com/cockpit-project/bots/commits/image-refresh-services-20231117-122941

@cockpituous
Copy link
Contributor Author

Completed. Log: Error accessing /repos/cockpit-project/bots/pulls
Status: 422
Reason: Unprocessable Entity
Response: {"message":"The specified issue is already attached to a pull request.","errors":[{"value":5557,"resource":"PullRequest","field":"issue","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

martinpitt
martinpitt approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still running, but looks very promising. @jelly can you please land if/when green?

@jelly
Copy link
Member

jelly commented Nov 17, 2023

Tests are still running, but looks very promising. @jelly can you please land if/when green?

Sure!

@jelly jelly merged commit 8c0d35a into main Nov 17, 2023
24 checks passed
@jelly jelly deleted the image-refresh-services-20231117-122322 branch November 17, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

@jelly jelly Awaiting requested review from jelly

Assignees
No one assigned
Labels
bot no-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockpituous @martinpitt @jelly