Makefile: Update Cockpit lib to 9da922928c1b1ea8489e12ba5ba6ecfd #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
github-actions
bot
commented
Nov 16, 2023
•
github-actions
bot
commented
- Requires lib: Fix race condition in "double dialog" error check cockpit#19616
- After that, update to that cockpit lib
github-actions
bot
changed the title
github-actions
bot
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022515
branch
from
2399033
to
690ae94
Compare
|
Test shows multiple dialogs on top of each other, see cockpit-project/cockpit#19595 . Let's fix! |
martinpitt
pushed a commit
that referenced
this pull request
Nov 16, 2023
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022515
branch
from
690ae94
to
b589a0f
Compare
|
Fixed. I did some other maintenance updates while I was it. |
martinpitt
added
the
blocked
martinpitt
pushed a commit
that referenced
this pull request
Nov 16, 2023
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022515
branch
2 times, most recently
from
0232f56
to
bbe382e
Compare
martinpitt
pushed a commit
that referenced
this pull request
Nov 16, 2023
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022515
branch
from
bbe382e
to
2ba1ac0
Compare
martinpitt
removed
the
blocked
martinpitt
pushed a commit
that referenced
this pull request
Nov 16, 2023
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022515
branch
from
2ba1ac0
to
0d5ad72
Compare
|
OK, let's skip fedora-37 then |
That way the config does not get out of date.
For the success cases, wait until the dialog goes away, and factorize checking that the file disappears from the main view.
Always close ConfirmDeletionDialog before showing ForceDeleteModal. Current cockpit lib warns on this situation, which will cause test failures.
The `__close` element is the parent div, clicking on it does nothing. As a result, the dialog stayed around, and the next one was opened over it.
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022515
branch
from
0d5ad72
to
d959be4
Compare
martinpitt
deleted the
cockpit-lib-update-cockpit-lib-20231116-022515
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.