Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add a canary for the last external snapshot issue #1687

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mvollmer
Copy link
Member

If the canary triggers, we can remove our workaround.

If the canary triggers, we can remove our workaround.
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's nice! The failures were unrelated flakes, retried.

@mvollmer
Copy link
Member Author

The failures were unrelated flakes, retried.

The anaconda-webui revdep test is currently broken because of pixel changes between Cockpit in rawhide and Cockpit main.

@mvollmer
Copy link
Member Author

The failures were unrelated flakes, retried.

The anaconda-webui revdep test is currently broken because of pixel changes between Cockpit in rawhide and Cockpit main.

Hmm, wait, the pixel conflicts come from cockpit-project/cockpit#20272 which was released in 318 which is in rawhide. shrug

@mvollmer
Copy link
Member Author

The failures were unrelated flakes, retried.

The anaconda-webui revdep test is currently broken because of pixel changes between Cockpit in rawhide and Cockpit main.

Hmm, wait, the pixel conflicts come from cockpit-project/cockpit#20272 which was released in 318 which is in rawhide. shrug

And this is cockpit-machines anyway, sorry, I was confused.

@mvollmer
Copy link
Member Author

Thanks, that's nice! The failures were unrelated flakes, retried.

The ubuntu failure seems persistent. I'll check.

@mvollmer
Copy link
Member Author

Thanks, that's nice! The failures were unrelated flakes, retried.

The ubuntu failure seems persistent. I'll check.

It's a sorting issue. The test expects test_snap_des to be first in the table, but it isn't when it has the same creation time as test_snap_1. I'll make a PR.

@mvollmer mvollmer merged commit 4be4e47 into cockpit-project:main Jun 20, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants