Makefile: Update Cockpit lib to 140b7e62f5cfcad5ad9105867474526ef68351db #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
github-actions
bot
commented
Nov 16, 2023
•
github-actions
bot
commented
- Requires lib: Fix race condition in "double dialog" error check cockpit#19616
- After that, update to that cockpit lib
github-actions
bot
changed the title
martinpitt
pushed a commit
that referenced
this pull request
Nov 16, 2023
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022509
branch
from
810f5df
to
49c9cf7
Compare
|
Test shows multiple dialogs on top of each other, see cockpit-project/cockpit#19595 . Let's fix! |
Close the error dialog in expectSearchErrorForNotExistingImage() and the image create dialog at the end of _testBasic() before clicking on the main page to open a new one. That is cheating, and also a race condition. Also wait for the successful download dialog to close before moving on to the next one.
martinpitt
force-pushed
the
cockpit-lib-update-cockpit-lib-20231116-022509
branch
from
49c9cf7
to
9cc6ce7
Compare
martinpitt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.