FIXUP conditional scrolling

test/common/test-functions.js

@@ -30,15 +30,17 @@ window.ph_find = function(sel) {
 
 window.ph_find_scroll_into_view = function(sel) {
     const el = window.ph_find(sel);
-    return el;
-    /*
     return new Promise(resolve => {
+        // is the element already visible? if so, we are done
+        const bounds = el.getBoundingClientRect();
+        if (bounds.top >= 0 && bounds.bottom <= window.innerHeight)
+            resolve(el);
+
+        // Otherwise, scroll it into view. That needs a little bit of time to stabilize, and
+        // it's not predictable; in particular, 'scrollend' is not reliably emitted
         el.scrollIntoView({ behaviour: 'instant', block: 'center', inline: 'center' });
-        // scrolling needs a little bit of time to stabilize, and it's not predictable
-        // in particular, 'scrollend' is not reliably emitted
         window.setTimeout(() => resolve(el), 200);
     });
-    */
 };
 
 window.ph_count = function(sel) {