Skip to content

Commit

Permalink
test: Reduce error message expectation for unreachable tang server
Browse files Browse the repository at this point in the history
stratis 3.6.0 changed its implementation from calling the cryptsetup CLI
to the API. This made the error message for an unreachable tang server
rather useless:

> Cryptsetup error: IO error occurred: Operation not permitted (os error 1)"

That is reported in https://bugzilla.redhat.com/show_bug.cgi?id=2246920
but fixing this will take a while. In the meantime, don't skip the rest
of the test via the naughty, but just adjust to current reality.

After that we can drop cockpit-project/bots#5469
  • Loading branch information
martinpitt committed Nov 3, 2023
1 parent e45e803 commit f1fe2a1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/verify/check-storage-stratis
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,10 @@ class TestStorageStratisNBDE(packagelib.PackageCase, storagelib.StorageCase):
tang_m.execute("systemctl stop tangd.socket")
b.click('#detail-header button:contains(Start)')
self.dialog_wait_open()
b.wait_in_text("#dialog", "Error communicating")
# stratis' error message for unreachable tang server is very poor:
# https://bugzilla.redhat.com/show_bug.cgi?id=2246920 Version < 3.6.0 said
# "Error communicating with server 10.111.112.5", check this again after fixing
b.wait_in_text("#dialog", "Error")
self.dialog_cancel()
self.dialog_wait_close()

Expand Down

0 comments on commit f1fe2a1

Please sign in to comment.