-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add TypeScript bindings for public base1.js APIs #13214
Conversation
@shaded-enmity Sorry for not getting attention here for a while. I am not sure though why we need the typescript bindings? |
@shaded-enmity do you plan to work on this still/explain why we would like this change? |
@KKoukiou It's mostly aimed at people who develop plugins for Cockpit, for example Patternfly4+React has been mostly rewritten in TypeScript. With this definition plugin developers get strong type checking and code completion. |
Once polished, the definitions should actually live in https://github.com/DefinitelyTyped/DefinitelyTyped/ so that they can be consumed in ecosystem-native way. |
@shaded-enmity, hi, it's been a year that this has not been updated. Do you want to keep this open and continue working on it? |
hey @KKoukiou, my time is extremely limited these days, here's what I can do:
However, that leaves a couple of outstanding items that I'd like to discuss & when agreed, get some help from the Cockpit community:
There's probably more things, this is just a quick list off the top of my head. Happy to discuss this in a call, |
@shaded-enmity hey sorry for the late reply. I am actually happy to help with some of these, but like you I can't commit to something time wise. The last question is, this PR is half ready, and not ready to be merged, so we can close it and keep tracking the items in a TODO list in an issue. |
Closing as of last comment not getting any reply. Thanks for taking the time! |
Such a shame this is not worked on. :-/ |
A new attempt... #19842 |
A placeholder PR for TypeScript typings for base1.js APIs
This covers a portion of the base1.js APIs that I used in the Leapp plugin for cockpit.
The typings can be used for type-checking in TypeScript as well as contextual code-completion when using the base1.js APIs, this PR is mostly meant to start a conversation rather than represent the final state.