Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Tell people that big mdraids really should have a bitmap #18979

Merged
merged 2 commits into from
Aug 8, 2023
Merged

storage: Tell people that big mdraids really should have a bitmap #18979

merged 2 commits into from
Aug 8, 2023

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Jun 20, 2023 •
edited
Loading

mdadm uses a bitmap for arrays that are larger than 100GiB, and not having a bitmap is a warning.

@mvollmer
Copy link
Member Author

turns out that mdadm actually decides itself whether or not a new mdraid device should use a bitmap or not, based on whether it makes sense or not.

@mvollmer mvollmer force-pushed the storage-mdraid-always-bitmap branch from 3b5d828 to 27926c9 Compare June 30, 2023 11:06
@mvollmer mvollmer changed the title storage: Tell people that mdraids really should have a bitmap storage: Tell people that big mdraids really should have a bitmap Jun 30, 2023
@mvollmer mvollmer force-pushed the storage-mdraid-always-bitmap branch from 27926c9 to 3b196e1 Compare June 30, 2023 12:17
@mvollmer mvollmer marked this pull request as ready for review June 30, 2023 12:17
@mvollmer mvollmer force-pushed the storage-mdraid-always-bitmap branch 4 times, most recently from 74c2903 to b5b683f Compare July 4, 2023 07:58
@mvollmer mvollmer force-pushed the storage-mdraid-always-bitmap branch 2 times, most recently from e693c8c to 494c797 Compare July 6, 2023 13:33
@mvollmer mvollmer added the blocked Don't land until something else happens first (see task list) label Jul 6, 2023
@martinpitt martinpitt marked this pull request as draft July 24, 2023 09:08
@martinpitt
Copy link
Member

Moving to draft while this is blocked and conflicty.

@mvollmer mvollmer force-pushed the storage-mdraid-always-bitmap branch from 494c797 to 35b8c38 Compare August 8, 2023 09:30
@mvollmer
test: Use sparse files to back loopback devices
236867f 
Then we can make them very big, as long as we don't write to them too
much.
@mvollmer mvollmer force-pushed the storage-mdraid-always-bitmap branch from 35b8c38 to 0a2021e Compare August 8, 2023 09:34
@mvollmer mvollmer marked this pull request as ready for review August 8, 2023 09:45
@mvollmer mvollmer removed the blocked Don't land until something else happens first (see task list) label Aug 8, 2023
jelly
jelly previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal looks good, some minor comments!

pkg/storaged/mdraid-details.jsx Outdated Show resolved Hide resolved
test/verify/check-storage-mdraid Outdated Show resolved Hide resolved
@mvollmer mvollmer force-pushed the storage-mdraid-always-bitmap branch from 0a2021e to e162d2f Compare August 8, 2023 12:37
@mvollmer mvollmer requested a review from jelly August 8, 2023 12:37
@mvollmer mvollmer merged commit 304b245 into cockpit-project:main Aug 8, 2023
89 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelly jelly jelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvollmer @martinpitt @jelly