Fetch path from url when loading terminal #19116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea seems fine to me, but please add a test for this. |
MahmoudHamdy02
force-pushed
the
add-terminal-path
branch
from
d5bad3b
to
ce356f2
Compare
cockpituous
reviewed
Jul 27, 2023
| @@ -33,7 +33,7 @@ const _ = cockpit.gettext; | |||
| environ: [ | |||
| "TERM=xterm-256color", | |||
| ], | |||
| directory: user.home || "/", | |||
| directory: cockpit.location.options.path || user.home || "/", | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will be used in Navigator to implement an "Open in terminal" button
cockpit-project/cockpit-files#68