-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Unified overview panel #19197
Conversation
a5fefa4
to
c2d96db
Compare
fdcff0f
to
74a0c8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
74a0c8b
to
173c562
Compare
ed6b0fa
to
93236d6
Compare
3d5224e
to
261de82
Compare
261de82
to
72d2987
Compare
Otherwise the order of PVs passed to calls like CreatePlainVolumeWithLayout depends on in which order the PVs have been selected in the dialog, which would not be wrong, but is unexpected.
So that extending this to "errors" in addition to "warnings" later on becomes slightly cleaner.
It gets spuriously closed sometimes.
This would otherwise interfere with clicks on table rows.
72d2987
to
0306f4b
Compare
Feedback for the last demo: overviewThe overview page is very extensive, maybe a bit too much data is shown. If I want to find information about my system's disks I usually look at For reference, gnome disks seems to do the same: However, I believe there is work being done on re-designing gnome disks. So maybe this design can also serve as some inspiration. empty vs unrecognizedRegarding unrecognized data, I agree that the current implementation can be a bit confusing. We should probably not show empty disks as that now seems to clutter the UI. And formalize if it will be "free" or "udisks does not know how to deal with fancy log based FS XYZ". actionsI think we need to improve the discoverability of actions such as making a stratis pool, RAID area. Maybe instead of a kebab this should be a dropdown or Menu? @garrett probably can provide a better suggestion, but I think overall it is not very easy for someone new to find that in the current design. breadcrumbsShould it not show: "raid array -> $raid member" instead of overview -> /dev/foo? |
0306f4b
to
4ecc45f
Compare
Continued in #19472 |
See #16440
Demos:
Todo
Polish
Notes