Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockpit.js: Add debugging marking for translated strings #19261

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

marusak
Copy link
Member

@marusak marusak commented Aug 30, 2023

I am still trying to understand how this would help, opening PR to demonstrate how we can do this.

Looks like this:
Screenshot from 2023-08-30 09-12-56

@tpardeshi
Copy link

Thanks @marusak for this pull request.
Enabling pseudo-localization markers will make it easy in automation for referencing and locating strings in the application, when it is running in preferred target localized language. It will be used to test the marked strings are translated on UI or not. Sometimes there are few cases where the strings(ex. Name of product, Name of services, etc) displayed in English language, can be detected as a bug in automation but in reality those happen to be displayed in English only and not in localized language. So pseudo-localization markers makes it easy to deal with such test scenario in automation. It would be really helpful if these markers get implemented for Cockpit .Thanks !!

@marusak
Copy link
Member Author

marusak commented Sep 25, 2023

@martinpitt what do you think about this? Could we land this and just see what output the translation team will provide us with?

@marusak marusak marked this pull request as ready for review September 25, 2023 08:59
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not super-convinced, but okay. This PR is already a month old, let's please refresh it and do the caching below.

pkg/lib/cockpit.js Outdated Show resolved Hide resolved
@martinpitt
Copy link
Member

@marusak is this still an issue?

@martinpitt martinpitt marked this pull request as draft December 1, 2023 09:53
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed "meh", but let's see what they make from it. Thanks!

@martinpitt martinpitt marked this pull request as ready for review January 12, 2024 08:37
@martinpitt martinpitt merged commit 1909d67 into cockpit-project:main Jan 12, 2024
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants