Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Explicitly trigger udev after resizing ext4 #19296

Merged

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Sep 8, 2023

UDisks2 now reads filesystem sizes from udev, which seems to sometimes need an extra trigger.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix a particular flake, OOI?

test/verify/check-storage-resize Outdated Show resolved Hide resolved
@mvollmer
Copy link
Member Author

mvollmer commented Sep 8, 2023

Does this fix a particular flake, OOI?

This one, hopefully: https://cockpit-logs.us-east-1.linodeobjects.com/pull-5216-20230907-051032-b39a4798-debian-testing-storage-cockpit-project-cockpit/log.html#43-2

TestStorageResize.testGrowShrinkHelp

UDisks2 now reads filesystem sizes from udev, which seems to sometimes
need an extra trigger.
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@martinpitt martinpitt added the flake unstable test label Sep 8, 2023
@martinpitt martinpitt merged commit 2e4bc9f into cockpit-project:main Sep 8, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake unstable test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants