apps: Fix crash with nonexisting /etc/os-release #19416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly check that the metapackage gets installed. This makes it easier to tell apart mere "too short timeout" failures from persistent ones.
2 tasks
mvollmer
requested changes
Sep 29, 2023
| m.write("/etc/os-release", 'ID="derivative"\nID_LIKE="spicy testy"\nVERSION_ID="1"\n') | ||
| b.click("#refresh") | ||
| with b.wait_timeout(30): | ||
| b.wait_visible(".app-list #app-1") | ||
| m.execute("until test -e /usr/share/app-info/xmls/test.xml; do sleep 1; done") |
There was a problem hiding this comment.
What about using b.wait for the loop? Then we can control the timeout in the usual way and don't need to wait for the global timeout when this fails.
There was a problem hiding this comment.
m.execute() has a default timeout of 2 minutes; it can be changed with timeout=, but the default seemed quite appropriate to me. We often use this pattern in our tests, see git grep -E 'execute.*(while|until)'
There was a problem hiding this comment.
and wait() (not b.wait() !) is more expensive, as it creates new SSH connections for each iteration.
There was a problem hiding this comment.
m.execute() has a default timeout of 2 minutes
Ah, I didn't think of that!
mvollmer
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out from PR #19281, as this is an embarassing crash/regression.