package.json: Drop unused cssnano-preset-lite, fix stylelint errors on main #19429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
no-test
jelly
previously approved these changes
Oct 4, 2023
Commit 6402df7 updated stylelint, but I foolishly didn't trigger the /devel scenario in that PR. Drop the deprecated "indentation" rule and suppress the `media-feature-range-notation` errors like we did in cockpit-machines. Also explicitly set `selector-not-notation`, as we use nontrivial selectors like `:not(:last-child)`.
martinpitt
changed the title
martinpitt
changed the title
jelly
reviewed
Oct 4, 2023
| @@ -4,8 +4,6 @@ | |||
| "stylelint-use-logical-spec" | |||
| ], | |||
| "rules": { | |||
| "indentation": 2, | |||
|
|
|||
There was a problem hiding this comment.
This seems suspicious? Why is it dropped?
There was a problem hiding this comment.
https://stylelint.io/migration-guide/to-15 and https://stylelint.io/user-guide/rules/indentation/ just say that it's deprecated, but not why 🤷♂️
There was a problem hiding this comment.
Ugh, well as the default is 2 anyway. LGTM.
There was a problem hiding this comment.
Oh, that could be? They want to stop supporting anything else than 2?
jelly
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.