kdump: always set kdump.conf defaults #19434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
added
the
no-test
martinpitt
reviewed
Oct 5, 2023
jelly
force-pushed
the
kdump-default-makedumpfile
branch
from
2940fd2
to
a32e96b
Compare
martinpitt
requested changes
Oct 10, 2023
jelly
removed
the
no-test
jelly
force-pushed
the
kdump-default-makedumpfile
branch
2 times, most recently
from
cd5300e
to
8715417
Compare
When an administrator clears core_collector setting and we save a new configuration the core_collector value is set to `makedumpfile` without arguments. This is an invalid setting for kdump and not what the kdump.conf man page recommends as default setting. The downside of hardcoding the default recommendation is that it may change over time, so this change includes a test to validate that when absent we re-set the default value.
jelly
force-pushed
the
kdump-default-makedumpfile
branch
from
8715417
to
5f779cb
Compare
cockpituous
reviewed
Oct 10, 2023
Comment on lines
+271
to
+272
| if (target.type === "ssh") { | ||
| settings._internal.core_collector.value += " -F"; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test. Details
| @@ -273,7 +280,7 @@ export class ConfigFile { | |||
| if ("core_collector" in settings._internal) | |||
| settings._internal.core_collector.value = settings._internal.core_collector.value + " -c"; | |||
| else | |||
| settings._internal.core_collector = { value: "makedumpfile -c" }; | |||
| settings._internal.core_collector = { value: defaultCoreCollector }; | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an administrator clears core_collector setting and we save a new configuration the core_collector value is set to
makedumpfilewithout arguments. This is an invalid setting for kdump and not what the kdump.conf man page recommends as default setting.The downside of hardcoding the default recommendation is that it may change over time, so this change includes a test to validate that when absent we re-set the default value.