workflows: Trigger anaconda test on bridge/storaged changes #19457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
no-test
martinpitt
force-pushed
the
anaconda-pr
branch
from
3142bc5
to
9106f3f
Compare
|
The run here did not trigger anything, as nothing is affected. Let me push an additional commit that changes the pybridge. (I originally tried to break it, but that would have to be subtle enough to still pass our unit tests, so that the rpm builds succeed -- I can't think of anything). This failed, I think it wants to tell me "I want read:org", but there's no such permission for the default GitHub token. So I reworked this to use our https://github.com/cockpituous token. |
martinpitt
force-pushed
the
anaconda-pr
branch
2 times, most recently
from
c939773
to
5c71a13
Compare
We want to make sure to not break Anaconda with changes which affect it, i.e. the bridge or the Storage page. As Anaconda's tests are "special" (require booting boot.iso, can't run in tmt/Testing Farm), we need to run them in Cockpit's CI. Add a workflow workflow which checks if the PR affects Anaconda (changes to the bridge or Storage page), polls the packit COPR until it has the current PR version available, and then test-triggers a "cockpit PR" scenario. https://issues.redhat.com/browse/COCKPIT-1064
martinpitt
force-pushed
the
anaconda-pr
branch
from
5c71a13
to
92f8ce0
Compare
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
martinpitt
force-pushed
the
anaconda-pr
branch
from
0c6b82e
to
31cb828
Compare
martinpitt
force-pushed
the
anaconda-pr
branch
from
31cb828
to
78fc6eb
Compare
martinpitt
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure to not break Anaconda with changes which affect it,
i.e. the bridge or the Storage page. As Anaconda's tests are "special"
(require booting boot.iso, can't run in tmt/Testing Farm), we need to
run them in Cockpit's CI.
Add a workflow workflow which checks if the PR affects Anaconda (changes
to the bridge or Storage page), polls the packit COPR until it has the
current PR version available, and then test-triggers a "cockpit PR"
scenario.
https://issues.redhat.com/browse/COCKPIT-1064
I developed/tested this on my fork in martinpitt#18 . Everything worked up to what I could expect from there (e.g. my fork isn't being watched by Cockpit CI). I also triggered a "cockpit PR" scenario in #19454 , i.e. the fedora-rawhide-boot/cockpit-pr-19454@rhinstaller/anaconda test.