Btrfs storage redesign #19512
Closed
Btrfs storage redesign #19512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
added
the
no-test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pkg/storaged/pages/other.jsx
Outdated
| props: { block } | ||
| }); | ||
|
|
||
| make_block_pages(p, block, null); |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments
pkg/storaged/pages/drive.jsx
Outdated
| }); | ||
|
|
||
| if (block.Size > 0) | ||
| make_block_pages(drive_page, block, null); |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments
| } else if ((content_block.IdUsage == "raid") || | ||
| (client.mdraids[content_block.MDRaidMember])) { | ||
| make_mdraid_disk_page(parent, block, content_block, container); | ||
| } else if (block_swap || (content_block && content_block.IdUsage == "other" && content_block.IdType == "swap")) { |
Check warning
Code scanning / CodeQL
Useless conditional Warning
pkg/storaged/pages/drive.jsx
Outdated
| import { SCard } from "../utils/card.jsx"; | ||
| import { SDesc } from "../utils/desc.jsx"; | ||
| import { StorageButton } from "../storage-controls.jsx"; | ||
| import { PageChildrenCard, ParentPageLink, new_page, page_type, block_location, register_crossref } from "../pages.jsx"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
test/verify/check-storage-stratis
Outdated
| b.wait_not_present("#devices .pf-v5-c-dropdown a:contains('Create Stratis pool')") | ||
| # XXX - explain this or make it more explicit | ||
| raid_clicks = self.dropdown_action(self.card_header("Storage"), "Create RAID device") | ||
| stratic_clicks = self.dropdown_action(self.card_header("Storage"), "Create Stratis pool") |
Check notice
Code scanning / CodeQL
Unused local variable
It gets spuriously closed sometimes.
All card actions are defined via the page and container abstractions, which will put them into the kebab menu of table rows. But then, dangerous and impossible actions are removed from that menu.
We could do the same in other places.
To be able to link to a BTRFS device in the BTRFS volume page we want to register all backing blocks to create link to btrfs volume devices.
This introduces the concept of BTRFS volumes in the storage page, a BTRFS volume can have multiple device(s). The first version won't implement adding/removing devices but should support showing them and making sense of it. We also show the btrfs subvolumes of a volume and should in the future allow creating of subvolumes under a subvolume and the root.
jelly
force-pushed
the
btrfs-redesign
branch
from
4c417d1
to
ca756b1
Compare
|
Partially implemented in #19690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Demo:
Screenshots:
Storage overview page
BTRFS Volume overview page
To Do:
fstabshould show up in the new storage overview re-design (For example now you won't see /home which is a btrfs subvolume but you do see /)qgroupin udisks? And creating of a qgroup? Needs more research, to be postponed for a follow upbtrfs subvolume create foois completely valid.