lib: provide an optional error callback for validation #19600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In podman we want to validate if the hostPath is correct, as this component returns an empty string on error and also as default state meaning we can't determine easily from an application.
cockpituous
reviewed
Nov 10, 2023
| @@ -184,7 +184,7 @@ export class FileAutoComplete extends React.Component { | |||
| onSelect={(_, value) => { | |||
| this.setState({ value, isOpen: false }); | |||
| this.debouncedChange(value); | |||
| this.props.onChange(value || ''); | |||
| this.props.onChange(value || '', null); | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
There was a problem hiding this comment.
We should maybe check if we get an error back. This PR would also be nice for reverse dependency testing with machines :)
There was a problem hiding this comment.
Can do! Submit a machines PR which uses it, then you can run that PR against this PR with https://packit.dev/posts/testing-farm-triggering
martinpitt
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In podman we want to validate if the hostPath is correct, as this component returns an empty string on error and also as default state meaning we can't determine easily from an application.
This should not break our API.