test: sudo stores an uid instead of a username since 1.9.15 #19602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed a security issue where a username could contain a path separator so now it uses an uid instead.
2 tasks
martinpitt
approved these changes
Nov 13, 2023
| @@ -69,6 +69,12 @@ class TestSuperuser(testlib.MachineCase): | |||
| self.restore_file("/var/lib/sudo/lectured/admin") | |||
| m.execute("rm -rf /var/{db,lib}/sudo/lectured/admin") | |||
|
|
|||
| # Sudo since 1.9.15 uses a UID not a username https://www.sudo.ws/releases/stable/#1.9.15 | |||
| uid = m.execute("id -u admin").strip() | |||
There was a problem hiding this comment.
I wonder why we don't simply restore_dir("/var/db/sudo/lectured") and remove all files in it.
There was a problem hiding this comment.
Ah, good question, happy to do that. Seems the test flakes a bit so I will retry it and then do a follow up once the image is merged
|
Meh, this flake is sticky. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed a security issue where a username could contain a path separator so now it uses an uid instead.