Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Fix race condition in "double dialog" error check #19616

Merged
merged 1 commit into from
Nov 16, 2023
Merged

lib: Fix race condition in "double dialog" error check #19616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkg/lib/dialogs.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,24 +97,29 @@
* Same as "Dialogs.show(null)".
*/

import React, { useState, useContext } from "react";
import React, { useContext, useRef, useState } from "react";

export const DialogsContext = React.createContext();
export const useDialogs = () => useContext(DialogsContext);

export const WithDialogs = ({ children }) => {
const is_open = useRef(false); // synchronous
const [dialog, setDialog] = useState(null);

const Dialogs = {
show: component => {
if (component && dialog !== null)
if (component && is_open.current)
console.error("Dialogs.show() called for",
JSON.stringify(component),
"while a dialog is already open:",
JSON.stringify(dialog));
is_open.current = !!component;
setDialog(component);
},
close: () => setDialog(null),
close: () => {
is_open.current = false;
setDialog(null);
},
isActive: () => dialog !== null
};

Expand Down