Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the eslint group with 2 updates #19635

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2023

Bumps the eslint group with 2 updates: eslint and eslint-plugin-jsx-a11y.

Updates eslint from 8.53.0 to 8.54.0

Release notes

Sourced from eslint's releases.

v8.54.0

Features

  • a7a883b feat: for-direction rule add check for condition in reverse order (#17755) (Angelo Annunziata)
  • 1452dc9 feat: Add suggestions to no-console (#17680) (Joel Mathew Koshy)
  • 21ebf8a feat: update no-array-constructor rule (#17711) (Francesco Trotta)

Bug Fixes

  • 98926e6 fix: Ensure that extra data is not accidentally stored in the cache file (#17760) (Milos Djermanovic)
  • e8cf9f6 fix: Make dark scroll bar in dark theme (#17753) (Pavel)
  • 3cbeaad fix: Use cwd constructor option as config basePath in Linter (#17705) (Milos Djermanovic)

Documentation

  • becfdd3 docs: Make clear when rules are removed (#17728) (Nicholas C. Zakas)
  • 05d6e99 docs: update "Submit a Pull Request" page (#17712) (Francesco Trotta)
  • eb2279e docs: display info about deprecated rules (#17749) (Percy Ma)
  • d245326 docs: Correct working in migrating plugin docs (#17722) (Filip Tammergård)

Chores

  • d644de9 chore: upgrade @​eslint/js@​8.54.0 (#17773) (Milos Djermanovic)
  • 1e6e314 chore: package.json update for @​eslint/js release (Jenkins)
  • 6fb8805 chore: Fixed grammar in issue_templates/rule_change (#17770) (Joel Mathew Koshy)
  • 85db724 chore: upgrade markdownlint to 0.31.1 (#17754) (Nitin Kumar)
  • 6d470d2 chore: update dependency recast to ^0.23.0 (#17736) (renovate[bot])
  • b7121b5 chore: update dependency markdownlint-cli to ^0.37.0 (#17735) (renovate[bot])
  • 633b9a1 chore: update dependency regenerator-runtime to ^0.14.0 (#17739) (renovate[bot])
  • acac16f chore: update dependency vite-plugin-commonjs to ^0.10.0 (#17740) (renovate[bot])
  • ba8ca7e chore: add .github/renovate.json5 (#17567) (Josh Goldberg ✨)
Changelog

Sourced from eslint's changelog.

v8.54.0 - November 17, 2023

  • d644de9 chore: upgrade @​eslint/js@​8.54.0 (#17773) (Milos Djermanovic)
  • 1e6e314 chore: package.json update for @​eslint/js release (Jenkins)
  • 98926e6 fix: Ensure that extra data is not accidentally stored in the cache file (#17760) (Milos Djermanovic)
  • a7a883b feat: for-direction rule add check for condition in reverse order (#17755) (Angelo Annunziata)
  • 1452dc9 feat: Add suggestions to no-console (#17680) (Joel Mathew Koshy)
  • 6fb8805 chore: Fixed grammar in issue_templates/rule_change (#17770) (Joel Mathew Koshy)
  • becfdd3 docs: Make clear when rules are removed (#17728) (Nicholas C. Zakas)
  • e8cf9f6 fix: Make dark scroll bar in dark theme (#17753) (Pavel)
  • 85db724 chore: upgrade markdownlint to 0.31.1 (#17754) (Nitin Kumar)
  • 21ebf8a feat: update no-array-constructor rule (#17711) (Francesco Trotta)
  • 05d6e99 docs: update "Submit a Pull Request" page (#17712) (Francesco Trotta)
  • eb2279e docs: display info about deprecated rules (#17749) (Percy Ma)
  • 6d470d2 chore: update dependency recast to ^0.23.0 (#17736) (renovate[bot])
  • b7121b5 chore: update dependency markdownlint-cli to ^0.37.0 (#17735) (renovate[bot])
  • 633b9a1 chore: update dependency regenerator-runtime to ^0.14.0 (#17739) (renovate[bot])
  • acac16f chore: update dependency vite-plugin-commonjs to ^0.10.0 (#17740) (renovate[bot])
  • ba8ca7e chore: add .github/renovate.json5 (#17567) (Josh Goldberg ✨)
  • 3cbeaad fix: Use cwd constructor option as config basePath in Linter (#17705) (Milos Djermanovic)
  • d245326 docs: Correct working in migrating plugin docs (#17722) (Filip Tammergård)
  • 5454c22 Revert "chore: remove metascraper (#17707)" (#17708) (Milos Djermanovic)
Commits

Updates eslint-plugin-jsx-a11y from 6.7.1 to 6.8.0

Changelog

Sourced from eslint-plugin-jsx-a11y's changelog.

v6.8.0 - 2023-11-01

Merged

Fixed

Commits

  • [Tests] migrate helper parsers function from eslint-plugin-react ce4d57f
  • [Refactor] use es-iterator-helpers 52de824
  • [New] mouse-events-have-key-events: add hoverInHandlers/hoverOutHandlers config db64898
  • [New] add polymorphicPropName setting for polymorphic components fffb05b
  • [Fix] isNonInteractiveElement: Upgrade aria-query to 5.3.0 and axobject-query to 3.2.1 64bfea6
  • [Refactor] use hasown instead of has 9a8edde
  • [actions] update used actions 10c061a
  • [Dev Deps] update @babel/cli, @babel/core, @babel/eslint-parser, @babel/plugin-transform-flow-strip-types, @babel/register, aud, eslint-doc-generator, eslint-plugin-import, minimist 6d5022d
  • [Dev Deps] update @babel/cli, @babel/core, @babel/eslint-parser, @babel/register, eslint-doc-generator, eslint-plugin-import 4dc7f1e
  • [New] anchor-has-content: Allow title attribute OR aria-label attribute e6bfd5c
  • [patch] mouse-events-have-key-events: rport the attribute, not the node eadd70c
  • [Deps] update @babel/runtime, array-includes, array.prototype.flatmap, object.entries, object.fromentries 46ffbc3
  • [Deps] update @babel/runtime, axobject-query, jsx-ast-utils, semver 5999555
  • [Fix] pin aria-query and axe-core to fix failing tests on main 8d8f016
  • [patch] move semver from Deps to Dev Deps 4da13e7
  • [Deps] update ast-types-flow b755318
  • [Dev Deps] update eslint-plugin-import f1c976b
  • [Deps] unpin language-tags 3d1d26d
  • [Docs] no-static-element-interactions: tabIndex is written tabindex 1271153
  • [Deps] Upgrade ast-types-flow to mitigate Docker user namespacing problems f0d2ddb
  • [Dev Deps] pin jackspeak since 2.1.2+ depends on npm aliases, which kill the install process in npm < 6 0c278f4
Commits
  • 9742753 v6.8.0
  • b755318 [Deps] update ast-types-flow
  • f1c976b [Dev Deps] update eslint-plugin-import
  • 52de824 [Refactor] use es-iterator-helpers
  • 9a8edde [Refactor] use hasown instead of has
  • 46ffbc3 [Deps] update @babel/runtime, array-includes, array.prototype.flatmap, ...
  • 4dc7f1e [Dev Deps] update @babel/cli, @babel/core, @babel/eslint-parser, `@babe...
  • fffb05b [New] add polymorphicPropName setting for polymorphic components
  • 3d1d26d [Deps] unpin language-tags
  • 10c061a [actions] update used actions
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@github-actions github-actions bot changed the title [no-test]: Bump the eslint group with 2 updates Bump the eslint group with 2 updates Nov 20, 2023
@martinpitt martinpitt force-pushed the dependabot/npm_and_yarn/eslint-0628be5fed branch from bc58499 to ae181d6 Compare November 20, 2023 21:53
@martinpitt martinpitt added no-test For doc/workflow changes, or experiments which don't need a full CI run, blocked Don't land until something else happens first (see task list) labels Nov 21, 2023
@martinpitt martinpitt marked this pull request as draft November 21, 2023 06:09
@martinpitt
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/eslint-0628be5fed branch from ae181d6 to d518707 Compare November 21, 2023 06:31
@martinpitt martinpitt removed the blocked Don't land until something else happens first (see task list) label Nov 21, 2023
@martinpitt martinpitt force-pushed the dependabot/npm_and_yarn/eslint-0628be5fed branch from d518707 to 2ade5b3 Compare November 21, 2023 06:37
@martinpitt martinpitt marked this pull request as ready for review November 21, 2023 06:41
@martinpitt
Copy link
Member

Bah, still this thing:

/work/bots/make-checkout-workdir/pkg/storaged/dialog.jsx
  784:37  error  A form label must be associated with a control  jsx-a11y/label-has-associated-control

@jelly any idea about this? I'll just draft/needswork this PR, as they keep coming back.

@martinpitt martinpitt marked this pull request as draft November 21, 2023 07:13
@jelly
Copy link
Member

jelly commented Nov 21, 2023

Bah, still this thing:

/work/bots/make-checkout-workdir/pkg/storaged/dialog.jsx
  784:37  error  A form label must be associated with a control  jsx-a11y/label-has-associated-control

@jelly any idea about this? I'll just draft/needswork this PR, as they keep coming back.

I looked at it in detail here #19559 (comment) and I still have no clue what's up honestly.

@jelly jelly force-pushed the dependabot/npm_and_yarn/eslint-0628be5fed branch from 2ade5b3 to 548bebc Compare November 21, 2023 09:18
@jelly jelly removed the needswork label Nov 21, 2023
Bumps the eslint group with 2 updates: [eslint](https://github.com/eslint/eslint) and [eslint-plugin-jsx-a11y](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y).

Updates `eslint` from 8.53.0 to 8.54.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.53.0...v8.54.0)

Updates `eslint-plugin-jsx-a11y` from 6.7.1 to 6.8.0
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-jsx-a11y@v6.7.1...v6.8.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint-plugin-jsx-a11y
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <support@github.com>
@jelly jelly removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Nov 21, 2023
@jelly jelly force-pushed the dependabot/npm_and_yarn/eslint-0628be5fed branch from 548bebc to 3522422 Compare November 21, 2023 10:06
@jelly jelly marked this pull request as ready for review November 21, 2023 11:56
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, nice -- this just looks like playing some dirty tricks with eslint's parser, but that's fine -- it tricked us first! 😝

@jelly
Copy link
Member

jelly commented Nov 21, 2023

Hah, nice -- this just looks like playing some dirty tricks with eslint's parser, but that's fine -- it tricked us first! 😝

Yes, not 100% satisfied with it, but I've no time to dig into the eslint rabbit hole I'm afraid.

@martinpitt
Copy link
Member

@jelly no, please don't -- IMHO this is absolutely a "pick your battles" case, clever workaround!

@martinpitt
Copy link
Member

Transient github API error, the tests were fine.

@martinpitt martinpitt merged commit 65dd4fc into main Nov 21, 2023
92 of 93 checks passed
@martinpitt martinpitt deleted the dependabot/npm_and_yarn/eslint-0628be5fed branch November 21, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants