storaged: set a dark hover background on mobile #19722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
requested changes
Dec 11, 2023
pkg/storaged/storage.scss
Outdated
| @@ -334,6 +334,10 @@ a.disabled { | |||
| background: var(--pf-v5-global--palette--black-150); | |||
| box-shadow: var(--pf-v5-global--BoxShadow--md); | |||
| cursor: pointer; | |||
|
|
|||
| .pf-v5-theme-dark & { | |||
| background: var(--ct-color-list-hover-bg); | |||
There was a problem hiding this comment.
--ct-color-list-hover-bg is the correct value also for light mode, let's just replace --pf-v5-global--palette--black-150 with it above, no need to have a special case for dark mode.
jelly
force-pushed
the
storage-mobile-dark-theme
branch
from
e695ba3
to
7d6bd4d
Compare
The palette black color is grey and causes a white flash when hovering over the storage devices in dark theme. The pf color switches color on hover correctly between dark and light color themes. Closes cockpit-project#19706
jelly
force-pushed
the
storage-mobile-dark-theme
branch
from
7d6bd4d
to
711c670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The palette black color is grey and causes a white flash when hovering over the storage devices in dark theme.
Closes #19706