storage: Be smart about default filesystem type #19854
Conversation
mvollmer
force-pushed
the
storage-better-default-fsys-type
branch
3 times, most recently
from
eaf4cdd
to
cee85e1
Compare
mvollmer
force-pushed
the
storage-better-default-fsys-type
branch
from
cee85e1
to
75b4b53
Compare
|
The code looks good to me, but I have questions about changing the default behavior from recommending xfs to now silently falling back to ext4. I wonder what the argument for the default being ext4 is? I know xfs is the RHEL blessed fs. |
This fallback should be exceedingly rare. Normally, the default is taken from the root filesystem, which is xfs on RHEL. Only if Cockpit does not support the filesystem type of the root filesystem (or can't find the root fs due to bugs) will it fall back to ext4. We can of course have a different fallback since it shouldn't really matter. I chose ext4 because I think it's the most standard Linux filesystem. |
|
Since my approval the pixel tests have changed, I'm happy to re-approve once that's fixed. |
mvollmer
force-pushed
the
storage-better-default-fsys-type
branch
from
75b4b53
to
23f3941
Compare
| @@ -155,6 +157,17 @@ export function format_dialog(client, path, start, size, enable_dos_extended) { | |||
| } | |||
| } | |||
|
|
|||
| function find_root_fsys_block() { | |||
| const root = client.anaconda?.mount_point_prefix || "/"; | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
No description provided.