Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockpit: sort polyfills imports #20738

Closed
wants to merge 1 commit into from

Conversation

jelly
Copy link
Member

@jelly jelly commented Jul 10, 2024

A newer ruff (0.5.1) is unhappy about it.


This has been bugging me locally for quite a while :D

A newer ruff (0.5.1) is unhappy about it.
@jelly
Copy link
Member Author

jelly commented Jul 10, 2024

# src/cockpit/polyfills.py:27:1: I001 [*] Import block is un-sorted or un-formatted
#    |
# 25 |       # introduced in 3.9
# 26 |       if not hasattr(socket, 'recv_fds'):
# 27 | /         import _socket
# 28 | |         import array
# 29 | | 
#    | |_^ I001
# 30 |           def recv_fds(sock, bufsize, maxfds, flags=0):
# 31 |               fds = array.array("i")

So ruff versions changed behaviour lol.

@jelly jelly closed this Jul 10, 2024
@martinpitt
Copy link
Member

Hm, ruff using locale based sorting and CI is using C and you are using nl_NL or so?

@jelly
Copy link
Member Author

jelly commented Jul 10, 2024

Hm, ruff using locale based sorting and CI is using C and you are using nl_NL or so?

I don't use nl_NL but en_GB but hm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants