pkg: cleanup ruff.toml exceptions #20805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires us to fix two easy violations.
This leaves one exclude which is hard to fix (undefined name F821) due to the nature how we run python scripts with inotify. We can't import inotify as we use our own inotify Python library which we concatenate before the executed script (for example mount-users.py).
martinpitt
approved these changes
Jul 26, 2024
Yeah, thought about that then realised that isn't doable without pre-pending inotify.py. But mount-users doesn't use inotify for example, so it is locally runnable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only tricky leftover is F821 due to the nature of how we use programs with
Inotifyfrom pkg/lib/inotify as we concatenate them while spawning.We can't do
Either as inotify is not in
sys.path, so that requires more hacks. And this spawning a warning that this is a real import.Potential bikeshed topic is that the shebang should be dropped from pkg/*.py? I have no strong opinion here.