Metrics use json helper #20935
Merged
Metrics use json helper #20935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Looks sane to me, thanks! But leaving the final review to @allisonkarlitskaya
| @@ -21,10 +21,10 @@ | |||
| import sys | |||
| import time | |||
| from collections import defaultdict | |||
| from typing import Dict, List, NamedTuple, Optional, Set, Tuple, Union | |||
| from typing import Dict, List, NamedTuple, Optional, Set, Tuple, Type, Union | |||
There was a problem hiding this comment.
I've generally grown to prefer using the built-in versions of the types along with quoting...
So, not:
from typing import Dict, Optional, Tuple, Type
x: Optional[Dict[str, Tuple[Type[Sampler], SampleDescription]]]but
x: 'dict[str, tuple[type[Sampler], SampleDescription]] | None'There was a problem hiding this comment.
Yeah but I mean the code is already there :)
allisonkarlitskaya
approved these changes
Aug 26, 2024
allisonkarlitskaya
merged commit eaf8973
into
cockpit-project:main
76 of 77 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same should be done for
metrics, useget_objvbut this was a drive by fix :)FYI: Type is Python 3.9 only, are we that modern already? 😅