storage: Never install packages on-demand in Anaconda mode #20950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
storage-no-installation-for-the-installer
branch
from
f7ed5a7
to
12e61ba
Compare
martinpitt
requested changes
Aug 28, 2024
test/verify/check-storage-anaconda
Outdated
|
|
||
| disk = self.add_loopback_disk(name="loop10") | ||
|
|
||
| m.execute("systemctl stop stratisd && dnf remove -y stratisd stratis") |
There was a problem hiding this comment.
This is destructive, so the test fails everywhere the second time around, and any stratis test that may run after it. Perhaps it's enough to systemctl mask the service? Or does it test for a file? If that's too hard, let's just make it destructive (but then preferably add it to an already existing destructive test)
Also, please don't use && in execute() calls. They already are set -e, and && has weird semantics.
There was a problem hiding this comment.
I have made it destructive.
mvollmer
force-pushed
the
storage-no-installation-for-the-installer
branch
from
12e61ba
to
c7f1827
Compare
martinpitt
previously approved these changes
Aug 29, 2024
mvollmer
force-pushed
the
storage-no-installation-for-the-installer
branch
from
c7f1827
to
60f3a41
Compare
martinpitt
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #20844