Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storaged: filter podman btrfs subvolumes #20956

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

jelly
Copy link
Member

@jelly jelly commented Aug 29, 2024

Podman btrfs subvolumes are an implementation detail of podman and not interesting for a Cockpit user in the storage page.

Closes: #20912

@jelly jelly requested a review from mvollmer August 29, 2024 14:52
@jelly
Copy link
Member Author

jelly commented Aug 30, 2024

On ubuntu there is no btrfs so creating a volume won't work, needs a new plan :)

test/verify/check-storage-btrfs Outdated Show resolved Hide resolved
Podman btrfs subvolumes are an implementation detail of podman and not
interesting for a Cockpit user in the storage page.

Closes: cockpit-project#20912
@jelly jelly force-pushed the btrfs-hide-podman-subvolumes branch from b948bde to 5d76bf8 Compare August 30, 2024 09:26
@jelly jelly requested a review from mvollmer August 30, 2024 11:23
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jelly
Copy link
Member Author

jelly commented Sep 2, 2024

CentOs 10 test failure is unrelated.

@jelly jelly merged commit 57c6347 into cockpit-project:main Sep 2, 2024
83 of 84 checks passed
@jelly jelly deleted the btrfs-hide-podman-subvolumes branch September 2, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: should allowed to fold or hide btrfs subvolumes
2 participants