shell: Navigate to new host after adding one #21004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mvollmer
commented
Sep 13, 2024
mvollmer
commented
- Shell: Extra warnings when connecting to remote hosts #20826
mvollmer
added
the
blocked
cockpituous
reviewed
Sep 13, 2024
Comment on lines
+100
to
+101
| componentWillUnmount() { | ||
| window.trigger_connection_flow = null; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
+152
to
+154
| if (machine == this.props.machine && parts.address != machine.address) { | ||
| this.props.loader.connect(parts.address); | ||
| this.props.jump(addr); |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
| try { | ||
| await try2Connect(this.props.machines, machine.connection_string); | ||
| connection_string = machine.connection_string; | ||
| } catch (err) { |
There was a problem hiding this comment.
This added line is not executed by any test.
| // continue with troubleshooting in the dialog | ||
| connection_string = await this.showModal({ | ||
| address: machine.address, | ||
| template: codes[err.problem] || "change-port", |
There was a problem hiding this comment.
This added line is not executed by any test.
| @@ -124,6 +196,8 @@ class AddMachine extends React.Component { | |||
| old_machine = props.machines_ins.lookup(props.old_address); | |||
| if (old_machine) | |||
| color = this.rgb2Hex(old_machine.color); | |||
| if (old_machine && !old_machine.visible) | |||
| old_machine = null; | |||
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+307
to
+308
| if (port_index === -1) { | ||
| host_id_port = address + ":22"; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
+990
to
+993
| if (machine && machine.host_key && !machine.on_disk) { | ||
| conn_options['temp-session'] = false; // Compatibility option | ||
| conn_options.session = 'shared'; | ||
| conn_options['host-key'] = machine.host_key; |
There was a problem hiding this comment.
These 4 added lines are not executed by any test.
Comment on lines
+109
to
+111
| .then(([result]) => { | ||
| if (result == "false" || result == "no") { | ||
| window.sessionStorage.setItem("connection-warning-shown", "yes"); |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
garrett
requested changes
Oct 9, 2024
|
Now part of #20826. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.