Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: cockpit: log channel instead of control #21023

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jelly
Copy link
Member

@jelly jelly commented Sep 18, 2024

Control messages are logged in the other if conditional and with this patch we log:

transport.ts:29 recv text message: 2:2!3 [[675520512.0]]

Instead of:

transport.ts:29 recv text message: null [[675520512.0]]

Control messages are logged in the other if conditional and with this
patch we log:

transport.ts:29 recv text message: 2:2!3 [[675520512.0]]

Instead of:

transport.ts:29 recv text message: null [[675520512.0]]
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd prefer a more thorough cleanup, but this is already an improvement.

pkg/lib/cockpit/_internal/transport.ts Show resolved Hide resolved
@martinpitt martinpitt merged commit 0a99601 into cockpit-project:main Sep 19, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants