flatpak: bump GNOME depend to 47 #21025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzzt |
allisonkarlitskaya
added
the
no-test
The new Sdk drops the old appstream-util command for favour of appstreamcli, so move to using it to validate our files.
allisonkarlitskaya
force-pushed
the
gnome-47
branch
from
907d3f1
to
50902de
Compare
We used to use this to disable the use of `.indent()` on our ElementTree (since it wasn't available on the Ubuntu version in GitHub Actions). The script which did that got removed in a33062f and this should have gone with it. Remove it now.
|
NB: this PR modifies the makefiles so in theory we could test it on all OSes but it only modifies the |
martinpitt
added
the
.github-changes
martinpitt
approved these changes
Sep 19, 2024
|
I built it and ran it, yes. Seems fine. |
allisonkarlitskaya
merged commit 44a60b9
into
cockpit-project:main
32 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Sdk drops the old appstream-util command for favour of appstreamcli, so move to using it to validate our files.
Fixes flathub/org.cockpit_project.CockpitClient#46