stats, encoding: improve UUID-decoding error

[michae2]

Add a length check to DecodeUUIDValue and a more informative error wrapping to DecodeUpperBound, which will hopefully help us track down the cause of #128876.

The wrapped error message looks like:

decoding histogram version 3 type uuid value ‹666f6f›: invalid uuid length of 2

Informs: #128876

Epic: None

Release note: None

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[yuzefovich]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @michae2, @mw5h, and @rytaft)

---

-- commits line 5 at r1:
nit: the sentence seems incomplete.

---

pkg/util/encoding/encoding.go line 3168 at r1 (raw file):

		return b, uuid.UUID{}, errors.Errorf("invalid uuid length of %d", len(b))
	}
	u, err = uuid.FromBytes(b[:uuidValueEncodedLength])

Nice! On a quick glance this seems like the only place in this file where we currently don't do bounds checks before slicing.

[michae2]

TFYR!

bors r=yuzefovich

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @mw5h and @rytaft)

---

-- commits line 5 at r1:

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: the sentence seems incomplete.

oh, it was an issue number with a # symbol, lol. fixed

[craig]

Build succeeded:

• local_roachtest
• linux_amd64_fips_build
• linux_arm64_build
• docker_image_amd64
• unit_tests
• acceptance
• macos_amd64_build
• local_roachtest_fips
• examples_orms
• windows_build
• lint
• macos_arm64_build
• check_generated_code
• linux_amd64_build

[michae2]

blathers backport 23.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 577f3e8 to blathers/backport-release-23.2-136015: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}