roachtest: run a read from standby workload on c2c/kv0 #136039
+223
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when using PCR reader catalog its was possible to hit "PCR reader timestamp has moved forward" when attempting to execute workloads. This was because internal executors are exempt from the AOST timestamp. To address this, the authentication code paths are updated to set fixed timestamps, when connecting to a PCR reader catalog. Additionally, additional tests are added for validating opening new connections and preparing queries to confirm this problem is fixed. Fixes: cockroachdb#135829 Release note: None
This patch adds a flag to the kv workload which elides preparing writing stmts in the kv workload. This flag will be used to run workloads on read from standby tenants in pcr tests. This flag is needed to begin the kv100 workload on the reader tenant becase: - preparing a writing stmt returns an error on during reader tenant connection aquisition. - Before this patch, the kv workload driver always prepared writing statments, even if kv100 was initialized. - If all reader conn's errored during acquisition, no workload could run on the reader tenant. Informs: cockroachdb#135829 Release note: none
msbutler
requested review from
nameisbhaskar,
vidit-bhat and
dt
and removed request for
a team
|
This change is |
|
first commit over in #135929 Evidence of the reader tenant workload working: |
This patch teaches the c2c roachtest driver to create a standby reader tenant and run a workload on it. These tools are then used to spin up a kv100 workload on the reader tenant in the c2c/kv0 roachtest. Epic: none Release note: none
msbutler
force-pushed
the
butler-kv100
branch
from
8ffe1a5
to
aaa3963
Compare
fqazi
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dt, @nameisbhaskar, and @vidit-bhat)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches the c2c roachtest driver to create a standby reader tenant
and run a workload on it. These tools are then used to spin up a kv100 workload
on the reader tenant in the c2c/kv0 roachtest.
Epic: none
Release note: none