Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Recent Releases table #19015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/current/releases/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ As of 2024, CockroachDB is released under a staged delivery process. New release

| Version | Release Type | GA date | Latest patch release |
| :---: | :---: | :---: | :---: |
| [v24.2](#v24-2) | Innovation | 2024-08-12 | v24.2.0 |
| [v24.1](#v24-1) | Regular | 2024-05-20 | v24.1.4 |
| [v23.2](#v23-2) | Regular | 2024-02-05 | v23.2.10 (LTS) |
| [v23.1](#v23-1) | Regular | 2023-05-15 | v23.1.25 (LTS) |
| [v24.2](#v24-2) | Innovation | 2024-09-25 | v24.2.3 |
Copy link
Contributor

@mdlinville mdlinville Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These GA dates do not look right to me when I look at the versions.csv, where the release_date for v24.2 is listed as 2024-08-12, for v24.1 it is listed as 2024-05-20, for v23.2 it is listed as 2024-02-05, etc. Where are you seeing these other dates?

The Latest patch release column is not ideal as it needs to be manually maintained. Is the column valuable enough to take that on, or to take on cycles to automate it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right; I updated these to the latest patch release date in error!

Also, you have a good point about maintainability — I think we should drop the column and I'll create an issue to consider automated display of it, instead.

I'll close this PR and open another, if that sounds good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

| [v24.1](#v24-1) | Regular | 2024-09-25 | v24.1.5 |
| [v23.2](#v23-2) | Regular | 2024-09-25 | v23.2.12 (LTS) |
| [v23.1](#v23-1) | Regular | 2024-10-10 | v23.1.28 (LTS) |

### Upcoming releases

Expand Down
Loading