Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-11624] Put back inadvertently-removed details about getting the IAM role / service account ID for CMEK #19070

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mdlinville
Copy link
Contributor

[DOC-11624] Put back inadvertently-removed details about getting the IAM role / service account ID for CMEK

Copy link

Files changed:

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit cf96d60
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67292707f0f1670008dd9b6e

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit cf96d60
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67292707025ba20008ae812e

Copy link

netlify bot commented Oct 30, 2024

Netlify Preview

Name Link
🔨 Latest commit cf96d60
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67292707fdfa3d000813409c
😎 Deploy Preview https://deploy-preview-19070--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@adwittumuluri adwittumuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we used to have docs that spelled out the service account that the customer should use? I feel like there was something that said "use crl-kms-user-{Last 12 digits of cluster UUID}@{account_id}.iam.gserviceaccount.com"

"cockroach_version": "v22.1.1",
"plan": "DEDICATED",
"cloud_provider": "GCP",
"account_id": "docs-rule-123",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth it to have an actual example, like crl-prod-xyz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@adwittumuluri
Copy link

Did we used to have docs that spelled out the service account that the customer should use?

Found it on the wayback machine 😆

@adwittumuluri
Copy link

I think this section will need to change to mirror what we used to have here for GCP. Namely, we need to tell the customer somewhere to use crl-kms-user-{CLUSTER_ID}@{PROJECT_ID}.iam.gserviceaccount.com. I don't think we do that anywhere right now.

@mdlinville
Copy link
Contributor Author

I think this section will need to change to mirror what we used to have here for GCP. Namely, we need to tell the customer somewhere to use crl-kms-user-{CLUSTER_ID}@{PROJECT_ID}.iam.gserviceaccount.com. I don't think we do that anywhere right now.

Done, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants