colblk: cache KeySeeker in the block metadata #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
We allow caching the KeySeeker in the block metadata, saving on initialization time. ``` name old time/op new time/op delta RandSeekInSST/v4/single-level-10 1.22µs ± 1% 1.22µs ± 1% ~ (p=0.565 n=7+7) RandSeekInSST/v4/two-level-10 2.07µs ± 3% 2.08µs ± 3% ~ (p=0.744 n=8+8) RandSeekInSST/v5/single-level-10 1.06µs ± 1% 1.01µs ± 1% -5.22% (p=0.000 n=8+8) RandSeekInSST/v5/two-level-10 1.60µs ± 3% 1.54µs ± 5% -3.17% (p=0.021 n=8+7) ```
RaduBerinde
force-pushed
the
cache-key-seeker
branch
from
e14cb43
to
1ad5f2a
Compare
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow caching the KeySeeker in the block metadata, saving on
initialization time.