crdb: fix untyped version seek, add tests #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
changed the title
This change adds tests for block encoding, suffix types, and key seek. It also fixes some bugs related to the suffix types.
The comparison when searching for an untyped version was in the wrong direction (suffixes are in reverse order).
RaduBerinde
force-pushed
the
crdb-block-tests
branch
from
5fe0e11
to
6c8d32b
Compare
jbowens
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
good catch
Reviewed 7 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crdbtest: add tests
This change adds tests for block encoding, suffix types, and key seek.
It also fixes some bugs related to the suffix types.
crdb: fix untyped version seek
The comparison when searching for an untyped version was in the wrong
direction (suffixes are in reverse order).