*: use crtime.NowMono instead of time.Now #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit updates crlib and changes the "production" parts of pebble to use `crtime.Mono` instead of `time.Time` or unix nanos. `NowMono()` is about 2x faster than `time.Now` (and is much cleaner than working with unix nanos). Informs cockroachdb/cockroach#133315
jbowens
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Reviewed 13 of 17 files at r1, all commit messages.
Reviewable status: 13 of 17 files reviewed, all discussions resolved (waiting on @aadityasondhi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates crlib and changes the "production" parts of pebble
to use
crtime.Monoinstead oftime.Timeor unix nanos.NowMono()is about 2x faster than
time.Now(and is much cleaner than workingwith unix nanos).
Informs cockroachdb/cockroach#133315