crl-release-24.2: sstable: fix restarts integer overflow #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug with integer overflows while indexing into blocks with large KVs in SeekGE() and SeekLT() in rowblk_iter. Updated members in blockEntry that represent offsets in blocks to be type offsetInBlock (alias for int64). Added check in rowblk_writer to ensure that block sizes do not exceed rowblk.MaximumSize before writing more data to the block. Wrote unit tests to verify correct behavior for SeekGE() and SeekLT() with large blocks >2GB.
|
This change is |
jbowens
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaduBerinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with integer overflows while indexing into blocks with large KVs in SeekGE() and SeekLT() in rowblk_iter. Updated members in blockEntry that represent offsets in blocks to be type offsetInBlock (alias for int64).
Added check in rowblk_writer to ensure that block sizes do not exceed rowblk.MaximumSize before writing more data to the block.
Wrote unit tests to verify correct behavior for SeekGE() and SeekLT() with large blocks >2GB.