test(metrics_extraction): Share create_widget usage (getsentry#65247)

code-watch · Feb 15, 2024 · 6ab4432 · 6ab4432
1 parent e3573e0
commit 6ab4432
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 82 deletions.
diff --git a/src/sentry/testutils/helpers/on_demand.py b/src/sentry/testutils/helpers/on_demand.py
@@ -0,0 +1,55 @@
+from collections.abc import Sequence
+
+from sentry.models.dashboard import Dashboard
+from sentry.models.dashboard_widget import (
+    DashboardWidget,
+    DashboardWidgetDisplayTypes,
+    DashboardWidgetQuery,
+    DashboardWidgetTypes,
+)
+from sentry.models.project import Project
+
+
+def create_widget(
+    aggregates: Sequence[str],
+    query: str,
+    project: Project,
+    title: str = "Dashboard",
+    id: int | None = None,
+    columns: Sequence[str] | None = None,
+    dashboard: Dashboard | None = None,
+    widget: DashboardWidget | None = None,
+) -> tuple[DashboardWidgetQuery, DashboardWidget, Dashboard]:
+    columns = columns or []
+    dashboard = dashboard or Dashboard.objects.create(
+        organization=project.organization,
+        created_by_id=1,
+        title=title,
+    )
+    order = (id or 1) - 1
+    widget = widget or DashboardWidget.objects.create(
+        dashboard=dashboard,
+        order=order,
+        widget_type=DashboardWidgetTypes.DISCOVER,
+        display_type=DashboardWidgetDisplayTypes.LINE_CHART,
+    )
+
+    if id:
+        widget_query = DashboardWidgetQuery.objects.create(
+            id=id,
+            aggregates=aggregates,
+            conditions=query,
+            columns=columns,
+            order=order,
+            widget=widget,
+        )
+    else:
+        widget_query = DashboardWidgetQuery.objects.create(
+            aggregates=aggregates,
+            conditions=query,
+            columns=columns,
+            order=order,
+            widget=widget,
+        )
+
+    return widget_query, widget, dashboard
diff --git a/tests/sentry/relay/config/test_metric_extraction.py b/tests/sentry/relay/config/test_metric_extraction.py
@@ -6,13 +6,7 @@
 from django.utils import timezone
 
 from sentry.incidents.models import AlertRule
-from sentry.models.dashboard import Dashboard
-from sentry.models.dashboard_widget import (
-    DashboardWidget,
-    DashboardWidgetDisplayTypes,
-    DashboardWidgetQuery,
-    DashboardWidgetTypes,
-)
+from sentry.models.dashboard_widget import DashboardWidgetQuery
 from sentry.models.environment import Environment
 from sentry.models.project import Project
 from sentry.models.transaction_threshold import ProjectTransactionThreshold, TransactionMetric
@@ -31,6 +25,7 @@
 from sentry.snuba.models import QuerySubscription, SnubaQuery
 from sentry.tasks.on_demand_metrics import process_widget_specs
 from sentry.testutils.helpers import Feature
+from sentry.testutils.helpers.on_demand import create_widget
 from sentry.testutils.helpers.options import override_options
 from sentry.testutils.pytest.fixtures import django_db_all
 
@@ -68,34 +63,6 @@ def create_alert(
     return alert_rule
 
 
-def create_widget(
-    aggregates: Sequence[str],
-    query: str,
-    project: Project,
-    title: str | None = "Dashboard",
-    columns: Sequence[str] | None = None,
-) -> DashboardWidgetQuery:
-    columns = columns or []
-    dashboard = Dashboard.objects.create(
-        organization=project.organization,
-        created_by_id=1,
-        title=title,
-    )
-
-    widget = DashboardWidget.objects.create(
-        dashboard=dashboard,
-        order=0,
-        widget_type=DashboardWidgetTypes.DISCOVER,
-        display_type=DashboardWidgetDisplayTypes.LINE_CHART,
-    )
-
-    widget_query = DashboardWidgetQuery.objects.create(
-        aggregates=aggregates, conditions=query, columns=columns, order=0, widget=widget
-    )
-
-    return widget_query
-
-
 def create_project_threshold(
     project: Project, threshold: int, metric: int
 ) -> ProjectTransactionThreshold:
@@ -634,7 +601,7 @@ def test_get_metric_extraction_config_multiple_widgets_above_max_limit_ordered_s
     with Feature({ON_DEMAND_METRICS_WIDGETS: True}):
         create_widget(["count()"], "transaction.duration:>=1000", default_project, "Dashboard 1")
         create_widget(["count()"], "transaction.duration:>=1100", default_project, "Dashboard 2")
-        widget_query = create_widget(
+        widget_query, _, _ = create_widget(
             ["count()"], "transaction.duration:>=1200", default_project, "Dashboard 3"
         )
         create_widget(["count()"], "transaction.duration:>=1300", default_project, "Dashboard 4")
@@ -1480,7 +1447,7 @@ def test_stateful_get_metric_extraction_config_enabled_with_multiple_versions(
             "organizations:on-demand-metrics-query-spec-version-two": True,
         }
     ):
-        widget_query = create_widget(
+        widget_query, _, _ = create_widget(
             ["epm()"],
             f"transaction.duration:>={duration}",
             default_project,
@@ -1777,7 +1744,7 @@ def test_include_environment_for_widgets(default_project: Project) -> None:
     condition: RuleCondition = {"name": "event.duration", "op": "gte", "value": 10.0}
 
     with Feature([ON_DEMAND_METRICS, ON_DEMAND_METRICS_WIDGETS]):
-        widget = create_widget([aggr], query, default_project)
+        widget, _, _ = create_widget([aggr], query, default_project)
         config = get_metric_extraction_config(default_project)
         # Because we have two specs we will have two metrics.
         # The second spec includes the environment tag as part of the query hash.
@@ -1833,7 +1800,7 @@ def test_include_environment_for_widgets_with_multiple_env(default_project: Proj
     ]
 
     with Feature([ON_DEMAND_METRICS, ON_DEMAND_METRICS_WIDGETS]):
-        widget_query = create_widget(aggrs, query, default_project, columns=columns)
+        widget_query, _, _ = create_widget(aggrs, query, default_project, columns=columns)
         config = get_metric_extraction_config(default_project)
         assert config
 
@@ -1882,7 +1849,7 @@ def test_alert_and_widget_colliding(default_project: Project) -> None:
     condition: RuleCondition = {"name": "event.duration", "op": "gte", "value": 10.0}
 
     with Feature([ON_DEMAND_METRICS, ON_DEMAND_METRICS_WIDGETS]):
-        widget = create_widget([aggr], query, default_project)
+        widget, _, _ = create_widget([aggr], query, default_project)
         config = get_metric_extraction_config(default_project)
         # Because we have two specs we will have two metrics.
         assert config and config["metrics"] == [
@@ -1950,7 +1917,7 @@ def test_event_type(
     aggr = "count()"
 
     with Feature([ON_DEMAND_METRICS, ON_DEMAND_METRICS_WIDGETS]):
-        widget = create_widget([aggr], query, default_project)
+        widget, _, _ = create_widget([aggr], query, default_project)
         config = get_metric_extraction_config(default_project)
         if not config_assertion:
             assert config is None
@@ -1983,7 +1950,7 @@ def test_widget_modifed_after_on_demand(default_project: Project) -> None:
             "organizations:on-demand-metrics-query-spec-version-two": True,
         }
     ):
-        widget_query = create_widget(
+        widget_query, _, _ = create_widget(
             ["epm()"],
             f"transaction.duration:>={duration}",
             default_project,

diff --git a/tests/sentry/tasks/test_on_demand_metrics.py b/tests/sentry/tasks/test_on_demand_metrics.py
@@ -4,14 +4,7 @@
 
 import pytest
 
-from sentry.models.dashboard import Dashboard
-from sentry.models.dashboard_widget import (
-    DashboardWidget,
-    DashboardWidgetDisplayTypes,
-    DashboardWidgetQuery,
-    DashboardWidgetQueryOnDemand,
-    DashboardWidgetTypes,
-)
+from sentry.models.dashboard_widget import DashboardWidgetQueryOnDemand
 from sentry.models.organization import Organization
 from sentry.models.project import Project
 from sentry.models.user import User
@@ -23,6 +16,7 @@
 )
 from sentry.testutils.factories import Factories
 from sentry.testutils.helpers import Feature, override_options
+from sentry.testutils.helpers.on_demand import create_widget
 from sentry.testutils.pytest.fixtures import django_db_all
 from sentry.utils.cache import cache
 
@@ -49,38 +43,6 @@ def project(organization: Organization) -> None:
     return Factories.create_project(organization=organization)
 
 
-# TODO: Move this into a method to be shared with test_metric_extraction
-def create_widget(
-    aggregates: Sequence[str],
-    query: str,
-    project: Project,
-    title: str = "Dashboard",
-    id: int | None = None,
-    columns: Sequence[str] | None = None,
-    dashboard: Dashboard | None = None,
-    widget: DashboardWidget | None = None,
-) -> tuple[DashboardWidgetQuery, DashboardWidget, Dashboard]:
-    columns = columns or []
-    dashboard = dashboard or Dashboard.objects.create(
-        organization=project.organization,
-        created_by_id=1,
-        title=title,
-    )
-    id = id or 1
-    widget = widget or DashboardWidget.objects.create(
-        dashboard=dashboard,
-        order=id - 1,
-        widget_type=DashboardWidgetTypes.DISCOVER,
-        display_type=DashboardWidgetDisplayTypes.LINE_CHART,
-    )
-
-    widget_query = DashboardWidgetQuery.objects.create(
-        id=id, aggregates=aggregates, conditions=query, columns=columns, order=id - 1, widget=widget
-    )
-
-    return widget_query, widget, dashboard
-
-
 @pytest.mark.parametrize(
     [
         "feature_flags",